[UpDown control] Forward HintAssist.HintPaddingBrush into nested TextBox of UpDown#3857
Merged
[UpDown control] Forward HintAssist.HintPaddingBrush into nested TextBox of UpDown#3857
Conversation
Keboo
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into a small issue when using the
UpDownvariants inside of a custom background (e.g. aColorZone). For the outlined style, the hint sits on top of the outline border when it is floating, and has a background set to hide the outline below the hint.For non-default backgrounds, the
HintAssist.HintPaddingBrushcan be used to ensure this behavior is maintained. However, this AP was not forwarded through in theUpDowncase. This PR does just that. Also fixed indentation, so possibly hiding whitespaces in the diff will show you a better diff.For this XAML
Before (AP not forwarded)

After (AP forwarded)
